#9466: square root with all=True should not return ValueError but empty list
-----------------------+----------------------------------------------------
Reporter: mstreng | Owner: AlexGhitza
Type: defect | Status: new
Priority: major | Milestone: sage-5.0
Component: algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
-----------------------+----------------------------------------------------
Comment(by mstreng):
Thanks! That bug has been around for too long :)
Why were you not able to fix the {{{FiniteField(9)}}} case?
Unfortunately, the patches need some more work, for the following three
reasons.
* With my2.patch:
{{{
sage: Zmod(7)(3).sqrt(extend=True)
sqrt3
sage: Zmod(7)(3).sqrt(all=True, extend=True)
[]
}}}
The second one should either output {{{[sqrt3, -sqrt3]}}} or raise
{{{NotImplementedError}}}, but never an empty list.
* Patches must have your name and email address in them. This is done by
putting your email address and name in your {{{.hgrc}}} file as specified
[http://www.sagemath.org/doc/developer/walk_through.html#submitting-a-change
here]
* Add an example of the new functionality to the documentation:
* This helps the user understand what the function does.
* Through the doctesting framework, this prevents other people from
accidentally breaking your added functionality.
* This is [http://www.sagemath.org/doc/developer/trac.html#reviewing-
patches required] for your patch to be able to get a positive review. In
fact, the manual says that you should also mention the ticket number #9466
with your example.
If you have any questions, let me know!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9466#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
