#7027: f2c ignores CC and uses gcc anyway
---------------------------------------------------------------+------------
Reporter: drkirkby |
Owner: tbd
Type: defect |
Status: needs_work
Priority: major |
Milestone: sage-5.0
Component: build |
Keywords:
Work_issues: remove unneeded files; possibly redundant patch |
Upstream: N/A
Reviewer: |
Author: R. Andrew Ohana
Merged: |
Dependencies:
---------------------------------------------------------------+------------
Changes (by mjo):
* status: needs_review => needs_work
* work_issues: => remove unneeded files; possibly redundant patch
Comment:
Why do we need both `patches/libf2c.makefile` and
`patches/libf2c.makefile.patch`? It looks to me like the patch does the
same thing as replacing the upstream makefile with libf2c.makefile:
{{{
$ diff -u src/libf2c/makefile patches/libf2c.makefile
--- src/libf2c/makefile 2007-08-14 21:26:15.000000000 -0400
+++ patches/libf2c.makefile 2012-02-10 04:31:00.000000000 -0500
@@ -70,10 +70,10 @@
### If your system lacks ranlib, you don't need it; see README.
f77vers.o: f77vers.c
- $(CC) -c f77vers.c
+ $(CC) -c $(CFLAGS) f77vers.c
i77vers.o: i77vers.c
- $(CC) -c i77vers.c
+ $(CC) -c $(CFLAGS) i77vers.c
# To get an "f2c.h" for use with "f2c -C++", first "make hadd"
hadd: f2c.h0 f2ch.add
}}}
{{{
$ cat patches/libf2c.makefile.patch
--- libf2c.makefile.orig 2009-01-20 00:22:57.000000000 -0800
+++ libf2c.makefile 2009-01-20 00:22:25.000000000 -0800
@@ -70,10 +70,10 @@
### If your system lacks ranlib, you don't need it; see README.
f77vers.o: f77vers.c
- $(CC) -c f77vers.c
+ $(CC) -c $(CFLAGS) f77vers.c
i77vers.o: i77vers.c
- $(CC) -c i77vers.c
+ $(CC) -c $(CFLAGS) i77vers.c
# To get an "f2c.h" for use with "f2c -C++", first "make hadd"
hadd: f2c.h0 f2ch.add
}}}
Is there a reason to keep both around and not just the patch?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7027#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
