#8983: erf(0) should return 0
---------------------------------------------+------------------------------
   Reporter:  rossk                          |          Owner:  RossK          
       Type:  enhancement                    |         Status:  positive_review
   Priority:  minor                          |      Milestone:  sage-5.0       
  Component:  symbolics                      |       Keywords:  erf, beginner  
Work_issues:                                 |       Upstream:  N/A            
   Reviewer:  Burcin Erocal, Douglas McNeil  |         Author:  Benjamin Jones 
     Merged:                                 |   Dependencies:                 
---------------------------------------------+------------------------------
Changes (by burcin):

  * status:  needs_review => positive_review


Comment:

 Replying to [comment:17 benjaminfjones]:
 > Maybe that's overkill, but it took me a while to find an input that
 actually reached the `x.is_trivial_zero()` branch.

 It's not overkill at all, after adding _a_ doctest to every function,
 perhaps we will measure the coverage in terms of percentage of lines
 executed with those tests. Thanks for spending the time and giving this
 function 100% coverage. :)

 BTW, `erf(SR(0))` should be a simple way of hitting the
 `is_trivially_zero()` branch.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8983#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to