#4949: Optionally build spkgs in $SAGE_BUILD_TMPDIR
-------------------------------------------------------------+--------------
Reporter: mabshoff | Owner:
mabshoff
Type: enhancement | Status:
needs_review
Priority: minor | Milestone:
sage-5.0
Component: build | Keywords:
sd32
Work_issues: | Upstream:
N/A
Reviewer: Mariah Lenox, Leif Leonhardy, Maarten Derickx | Author:
John Palmieri
Merged: | Dependencies:
-------------------------------------------------------------+--------------
Changes (by jhpalmieri):
* status: needs_work => needs_review
Comment:
Replying to [comment:50 jdemeyer]:
> Lines 210 and 216 of `sage-spkg`: you have twice cd "$SAGE_BUILD_DIR".
Remove the second and move the check (line 219) up, after the first cd.
You probably want to "exit 1" if cd fails.
Well, the old version had a second 'cd' command, justified by the comment
{{{
# Make triply sure that we are in the build directory before doing
# a scary "rm -rf"
}}}
So I left the second one in. You think I should change this? In any
case, you're right about the "exit 1".
> Line 227 of `sage-spkg`: replace
{{{
if [ -e "$dir" ]; then
}}}
> by
{{{
if [ -d "$dir" ]; then
}}}
On the off-chance that there is a file (not a directory) in the build
directory with the wrong name, shouldn't we move it, too?
Replying to [comment:51 jdemeyer]:
> Line 235: why "mv -f" and not simply "mv"?
Left over from the previous version. I can fix that.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4949#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
