#12452: make it possible to inherit from sage.symbolic.expression.Expression.
-------------------------------------------------+--------------------------
   Reporter:  burcin                             |          Owner:  burcin      
 
       Type:  enhancement                        |         Status:  
needs_review 
   Priority:  minor                              |      Milestone:  sage-5.0    
 
  Component:  symbolics                          |       Keywords:  Cernay2012  
 
Work_issues:                                     |       Upstream:  N/A         
 
   Reviewer:  Jean-Pierre Flori, Florent Hivert  |         Author:  Burcin 
Erocal
     Merged:                                     |   Dependencies:              
 
-------------------------------------------------+--------------------------

Comment(by burcin):

 Replying to [comment:4 hivert]:
 > I hope you now feel better and that you had a nice and safe way home.

 Thanks. I'm back at work now. Unfortunately, I'll only be able to take a
 look at the indexed expressions (#11576) first week of March.

 > The code looks good to me to and I got a all test passed on a
 sage-5.0.beta4. So I'm tempted to set a positive review. However, before
 doing that I'd like to answer the two following questions:
 >
 >   - as such, does it solve any problem we had with the former
 implantation of Expression ? For example I asked for this feature to be
 able to have indexed variables but I don't think I can do it with the
 current patch. Of course I realize that it won't be the right solution
 since we can go directly using PyNAC

 No, this will not solve your problem. It only allows one to carry around
 some information with symbolic expressions. Even then, to handle the
 propagation of that info, you'd have to implement many methods yourself.

 I'm not convinced if there is a real use case for this actually. There
 were many requests on sage-support, but AFAICT, all those actually needed
 indexed expressions not their own expression class.

 >   - is there any measurable slowdown because of the extra work ?

 Yes, definitely:

 http://groups.google.com/group/sage-support/msg/511d84f6d744621e

 That was based on an earlier version of this patch.

 > So if you don't mind I'd like to experiment a little more before putting
 the positive review.

 Sure. I appreciate a thorough review.

 I'd also be happy to just leave this patch on trac until somebody comes up
 with a real use case.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12452#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to