#7980: Implement generic support for parents with (multiple) realizations
------------------------------------------+---------------------------------
Reporter: jbandlow | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: categories | Keywords: Cernay2012
Work_issues: | Upstream: N/A
Reviewer: Simon King, Florent Hivert | Author: Nicolas M. Thiéry
Merged: | Dependencies: #12484, #12464
------------------------------------------+---------------------------------
Comment(by nthiery):
Replying to [comment:9 hivert]:
> I just posted a review patch on sage-combinat queue.
Thanks!
I went through it, folded it in, and added a
[http://combinat.sagemath.org/patches/file/tip/trac_7980-multiple-
realizations-review-nt.patch
review review patch]
> 1. This is mostly documentation, except that I changed trivially the
code in
> the example, by renaming some parameter names:
>
> - in {{{SubsetAlgebra(S)}}} the parameter S is a set;
>
> - in {{{Fundamental(S)}}}, {{{In(S)}}} and {{{Out(S)}}} it is a
> {{{SubsetAlgebra}}};
>
> I was really confused about that reading the code so that I renamed
{{{S}}}
> to {{{SAlg}}} in the second case and added an {{{INPUT:}}} field in the
doc
Good point. I ended up renaming SAlg to A since this is what we use in
all the examples.
> 3. There is a missing doctest in my review patch
> {{{
> sage: A.F() in A.Realizations()
> Expected:
> True
> Got:
> False
> }}}
Ouch! That's not good. I am not sure this is the best approach, but I
added A.Realizations() to the super categories Bases(A). Maybe
A.Realizations() should be Bases(A) instead. In any cases, that will
work for now. I added A._test_realizations() which checks:
{{{
R in A.Realizations() for R in A.realizations()
}}}
Feel free to fold in my review patch and repost after checking it out.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7980#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
