#12064: Update residue fields to use dynamic classes
-----------------------------+----------------------------------------------
Reporter: roed | Owner: davidloeffler
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: number fields | Keywords: residue fields, dynamic classes
Work_issues: | Upstream: N/A
Reviewer: spice | Author: David Roe
Merged: | Dependencies: #12062
-----------------------------+----------------------------------------------
Changes (by spice):
* status: needs_review => needs_work
Comment:
Looks like there's new trouble when trying to apply 12064 on top of 12062.
12062 has already been applied and Sage built in the output below:
{{{
sage@sagebox:~/sage/devel/sage$ hg qpush
applying 12064.patch
patching file sage/rings/finite_rings/finite_field_base.pyx
Hunk #1 succeeded at 90 with fuzz 2 (offset -2 lines).
patching file sage/rings/residue_field.pyx
Hunk #3 succeeded at 139 with fuzz 2 (offset 0 lines).
Hunk #8 succeeded at 435 with fuzz 2 (offset 0 lines).
now at: 12064.patch
sage@sagebox:~/sage/devel/sage$ sage -b
----------------------------------------------------------
sage: Building and installing modified Sage library files.
Installing c_lib
scons: `install' is up to date.
Updating Cython code....
Building modified file sage/rings/residue_field.pyx.
Building modified file sage/rings/finite_rings/finite_field_base.pyx.
Executing 2 commands (using 1 thread)
python `which cython` --old-style-globals --disable-function-redefinition
--embed-positions --directive
cdivision=True,autotestdict=False,fast_getattr=True
-I/Users/sage/sage-4.8/devel/sage-dev1 -o sage/rings/residue_field.c
sage/rings/residue_field.pyx
Error compiling Cython file:
------------------------------------------------------------
...
K = pring.fraction_field()
intp = pring.base_ring().order()
f = p.gen()
deg = f.degree()
q = intp**deg
if k == 1 and intp.is_prime() and (impl is None or impl ==
'modn'):
^
------------------------------------------------------------
sage/rings/residue_field.pyx:313:17: local variable 'k' referenced before
assignment
python `which cython` --old-style-globals --disable-function-redefinition
--embed-positions --directive
cdivision=True,autotestdict=False,fast_getattr=True
-I/Users/sage/sage-4.8/devel/sage-dev1 -o
sage/rings/finite_rings/finite_field_base.c
sage/rings/finite_rings/finite_field_base.pyx
Error running command, failed with status 256.
sage: There was an error installing modified sage library code.
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12064#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
