#12053: Ideals in p-adic rings
---------------------------+------------------------------------------------
   Reporter:  roed         |          Owner:  roed      
       Type:  enhancement  |         Status:  needs_info
   Priority:  major        |      Milestone:  sage-5.0  
  Component:  padics       |       Keywords:            
Work_issues:               |       Upstream:  N/A       
   Reviewer:               |         Author:  David Roe 
     Merged:               |   Dependencies:            
---------------------------+------------------------------------------------

Comment(by dmharvey):

 What is {{{reduce()}}} supposed to do? I don't understand that function.

 This is a little alarming:

 {{{
 sage: ~R.ideal(5) * 5
 Fractional ideal (5^-1) of 5-adic Field with capped relative precision 20
 }}}

 But I see fractional ideals are not implemented. Perhaps there should be a
 {{{NotImplementedError}}} somewhere rather than manifestly incorrect
 behaviour. Is this fixed in a later patch?

 I agree with saraedum's comment above, but for the moment it wouldn't hurt
 for it to live in padics/, especially as all that code is under heavy
 active development at the moment.

 It wouldn't hurt to add some doctests to cover some unramified and
 ramified extensions of Zp (I tried a few myself and everything seems to
 work).

 Apart from these issues the patch looks good to me.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12053#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to