#9744: implicit_plot fill option fills entire plot
-----------------------------------+----------------------------------------
   Reporter:  jason                |          Owner:  jason, was                
                  
       Type:  defect               |         Status:  needs_review              
                  
   Priority:  critical             |      Milestone:  sage-5.0                  
                  
  Component:  graphics             |       Keywords:                            
                  
Work_issues:                       |       Upstream:  N/A                       
                  
   Reviewer:  Karl-Dieter Crisman  |         Author:  Jason Grout, Michael 
Boratko, Benjamin Jones
     Merged:                       |   Dependencies:                            
                  
-----------------------------------+----------------------------------------

Comment(by kcrisman):

 I'm between classes now, but I'll check it out later.  In the meantime,
 what is going on with the new code?  When is the last line
 {{{
 return contour_plot(f, xrange, yrange, linewidths=linewidths,
 linestyles=linestyles, **options)
 }}}
 ever reached?

 Also,
 {{{
 if options.pop('fill'):
 }}}
 will give a `KeyError` if `'fill'` isn't defined in the options
 dictionary.  Could that happen?  If so, you may want to take the previous
 entry
 {{{
 if 'color' in options:
 }}}
 and go from there... this may not be a problem, but it's probably wisest
 to guard against it.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9744#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to