#12581: Fix contour and other plot default aspect ratio
------------------------+---------------------------------------------------
   Reporter:  kcrisman  |          Owner:  jason, was
       Type:  defect    |         Status:  new       
   Priority:  critical  |      Milestone:  sage-5.0  
  Component:  graphics  |       Keywords:            
Work_issues:            |       Upstream:  N/A       
   Reviewer:            |         Author:            
     Merged:            |   Dependencies:            
------------------------+---------------------------------------------------

Old description:

> {{{
> On Feb 24, 3:04 pm, kcrisman <[email protected]> wrote:
> > Jason, what's going on with
> >
> > x,y = var('x,y')
> > contour_plot(x^2+y^2-2,(x,-1,1), (y,-1,1))
>
> This was due to http://trac.sagemath.org/sage_trac/ticket/12213, and not
> fixed by #12222, because that only focused on shape primitives.
> }}}
>
> The fix is most likely to add an option in the decorators of all the
> contour_plot.py commands to put aspect ratio back to 1 for those things.
>
> Critical because we have in the past long discussed this; I would like to
> make it blocker since
> {{{
> This should plot concentric circles centered at the origin::
>
>         sage: x,y = var('x,y')
>         sage: contour_plot(x^2+y^2-2,(x,-1,1), (y,-1,1))
> }}}
> doesn't look like circles, but I suppose that they ''are'' circles...

New description:

 {{{
 On Feb 24, 3:04 pm, kcrisman <[email protected]> wrote:
 > Jason, what's going on with
 >
 > x,y = var('x,y')
 > contour_plot(x^2+y^2-2,(x,-1,1), (y,-1,1))

 This was due to http://trac.sagemath.org/sage_trac/ticket/12213, and not
 fixed by #12222, because that only focused on shape primitives.
 }}}

 The fix is most likely to add an option in the decorators of all the
 contour_plot.py commands to put aspect ratio back to 1 for those things.

 Critical because we have in the past long discussed this; I would like to
 make it blocker since
 {{{
 This should plot concentric circles centered at the origin::

         sage: x,y = var('x,y')
         sage: contour_plot(x^2+y^2-2,(x,-1,1), (y,-1,1))
 }}}
 doesn't look like circles, but I suppose that they ''are'' circles...

 Apply [attachment:trac_12581-aspect_ratio.patch].

--

Comment(by kcrisman):

 This ''might'' depend on #9744.  I don't think it touches the same parts
 of contour_plot.py, but if you get a problem applying, then it does.  Note
 that we don't need the option for `implicit_plot` because it always gives
 a region plot or a contour plot.

 For reviewing; please test whether this breaks anything from #11963.  I
 don't quite understand what the 'correct' summation behavior is yet.  I
 assume that this works okay, though.

 And a question; should it be `1.0` instead of `1`?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12581#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to