#12341: Empty (full) cremona database in Sage 4.8 causes tests to fail
-------------------------------+--------------------------------------------
   Reporter:  swenson          |          Owner:  cremona        
       Type:  defect           |         Status:  needs_review   
   Priority:  critical         |      Milestone:  sage-5.0       
  Component:  elliptic curves  |       Keywords:                 
Work_issues:                   |       Upstream:  N/A            
   Reviewer:  John Cremona     |         Author:  R. Andrew Ohana
     Merged:                   |   Dependencies:                 
-------------------------------+--------------------------------------------
Changes (by cremona):

  * reviewer:  => John Cremona


Comment:

 Patch applies fine and all elliptic_curves tests pass both before and
 after installing the optional database (which with 5.0.bets5 I installed
 with a plain "sage -i database_cremona_ellcurve").

 I have not checked all the logic in the revised code.  I was puzzled by
 the remark about testing with flag --optional since I thought that only
 made sense with some sensible string after the word "optional", e.g.
 "magma".  But it seems that there are doctest lines which are tagged "#
 optional" with no mention of which optional package is relevant.  Possibly
 for this reason, I had weird failures with
 {{{
 sage -t --optional devel/sage-
 main/sage/schemes/elliptic_curves/lseries_ell.py # 3 doctests failed
 }}}
 which may have nothing to do with this ticket.

 I hesitate to set this to Positive Review since I really don't understand
 what it going on, but at least I have done something and reported what has
 happened.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12341#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to