#12604: A patch adding .dimensions() to a matrix.
-----------------------------+----------------------------------------------
Reporter: blundell | Owner: tbd
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: sage-5.0
Component: PLEASE CHANGE | Keywords: Matricies
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by was):
REFEREE REPORT:
1. It fails all the doctests:
{{{
wstein@sage:/scratch/wstein/sage-5.0.beta5-sage.math.washington.edu-x86_64-Linux/devel/sage/sage$
sage -t matrix/matrix0.pyx
sage -t "devel/sage-main/sage/matrix/matrix0.pyx"
**********************************************************************
File
"/mnt/usb1/scratch/wstein/sage-5.0.beta5-sage.math.washington.edu-x86_64-Linux/devel
/sage-main/sage/matrix/matrix0.pyx", line 2028:
sage: M.dimensions()
Expected:
(2,3)
Got:
(2, 3)
**********************************************************************
File
"/mnt/usb1/scratch/wstein/sage-5.0.beta5-sage.math.washington.edu-x86_64-Linux/devel
/sage-main/sage/matrix/matrix0.pyx", line 2030:
sage: N.dimensions()
Expected:
(3,2)
Got:
(3, 2)
**********************************************************************
1 items had failures:
2 of 7 in __main__.example_35
***Test Failed*** 2 failures.
For whitespace errors, see the file
/scratch/wstein/sage//tmp/matrix0_29905.py
[6.3 s]
}}}
2. The description in the patch should probably be "Trac #12604: Added a
method to a matrix which gives the dimensions."
3. The author should be "Ben Lundell" instead of math480 student.
I've attached a patch fixing all these issues.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12604#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
