#12611: Add optional argument 'p' in valuation() and ordp() methods for padics
---------------------------+------------------------------------------------
Reporter: mmasdeu | Owner: tbd
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-5.0
Component: padics | Keywords: padics, valuation, ordp
Work_issues: | Upstream: N/A
Reviewer: | Author: Marc Masdeu
Merged: | Dependencies:
---------------------------+------------------------------------------------
Changes (by roed):
* status: needs_review => needs_work
Comment:
Looks good. The one change I would suggest is to explain in the docstring
that the reason for allowing p as input is for consistency with the
valuation methods on integer and rational.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12611#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
