#12612: Fix is_unit() in padics so that it is mathematically correct
-----------------------+----------------------------------------------------
Reporter: mmasdeu | Owner: roed
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: padics | Keywords: padics is_unit
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
-----------------------+----------------------------------------------------
Changes (by roed):
* status: new => needs_review
Comment:
I think you need to add an explanation in the docstring of `is_unit`
explaining why the change has been made, and pointing at the
`is_padic_unit` function as a replacement for the old behavior. Other
than that, the patch looks fine in principle, though I need to run the
doctests.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12612#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
