#12599: setuptools: make spkg-install executable
---------------------------------+------------------------------------------
   Reporter:  jdemeyer           |          Owner:  tbd            
       Type:  defect             |         Status:  positive_review
   Priority:  minor              |      Milestone:  sage-5.0       
  Component:  packages           |       Keywords:                 
Work_issues:                     |       Upstream:  N/A            
   Reviewer:  Jean-Pierre Flori  |         Author:  Jeroen Demeyer 
     Merged:                     |   Dependencies:                 
---------------------------------+------------------------------------------
Changes (by jpflori):

  * status:  needs_review => positive_review


Comment:

 Sorry, I was not clear.

 It's obviously not reflected in what hg log outputs but in what hg diff
 -rx:y would with git=true.

 It's also true that this is generated on the fly, so my comment was kind
 of meaningless, I was just surprised the diff you posted here did not
 include that change (and anyway you must have generated it with the
 git=true option but only on SPKG.txt and not all the repo).

 So I'm putting that back to positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12599#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to