#12629: Fix Linbox DISABLE_COMMENTATOR
------------------------+---------------------------------------------------
   Reporter:  jdemeyer  |          Owner:  tbd     
       Type:  defect    |         Status:  new     
   Priority:  blocker   |      Milestone:  sage-5.0
  Component:  packages  |       Keywords:          
Work_issues:            |       Upstream:  N/A     
   Reviewer:            |         Author:          
     Merged:            |   Dependencies:          
------------------------+---------------------------------------------------
Changes (by jdemeyer):

  * priority:  critical => blocker


Old description:

> Linbox has its infamous `DISABLE_COMMENTATOR` #define.  When compiling
> code with this flag set, the commentator is disabled.  But Linbox itself
> is compiled with the commentator enabled.  The problem is that
> commentator-enabled code is not compatible with commentator-disabled code
> because of C++ constructors/destructors.
>
> Proposed solution: in the "disabled" commentator, still keep the member
> variables of the real commentator, disable only the member functions.

New description:

 Linbox has its infamous `DISABLE_COMMENTATOR` #define.  When compiling
 code with this flag set, the commentator is disabled.  But Linbox itself
 is compiled with the commentator enabled.  The problem is that
 commentator-enabled code is not compatible with commentator-disabled code
 because of C++ constructors/destructors.

 Proposed solution: '''always''' disable the commentator.

--

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12629#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to