#12544: Switch cones to `PointCollection`
---------------------------+------------------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: geometry | Keywords: toric
Work_issues: | Upstream: N/A
Reviewer: | Author: Andrey Novoseltsev
Merged: | Dependencies: #11599, #12541
---------------------------+------------------------------------------------
Changes (by novoselt):
* status: new => needs_review
* dependencies: #12541 => #11599, #12541
Old description:
> The class `PointCollection` at #11400 is intended for uniform handling of
> ray/line generators and their subsets for cones, fans, and, eventually,
> lattice polytopes. This ticket is about making the switch for cones.
New description:
The class `PointCollection` at #11400 is intended for uniform handling of
ray/line generators and their subsets for cones, fans, and, eventually,
lattice polytopes. This ticket is about making the switch for cones.
'''Apply:'''
* [attachment:trac_12544_switch_cones_to_PointCollection.patch]
* [attachment:trac_12544_fix_doctests.patch]
* [attachment:trac_12544_deprecate_old_ray_methods.patch]
--
Comment:
I've tried to break changes into several patches, although they got bigger
and bigger. However, despite of the total size, these patches should be
easy to review as they don't do anything deep - a few conversion methods,
a few deprecations, and a lot of doctest changes due to different output
formatting.
Personally, I am quite pleased with the results - while some calls got a
few more characters, one of the most important methods for cones and fans
now produces convenient output with a detailed but not repeated
description of the ambient lattice. This worked especially well for
quotients and sublattices, whose description was not obvious from ray
output before. Hopefully, that's not just my point of view and the changes
are objectively for the best ;-)
I have #11599 in the beginning of my queue now, so this ticket is based on
top of it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12544#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
