#12585: Bring matrix/matrix0.pyx to 100% coverage
---------------------------------------------------+------------------------
Reporter: hthomas | Owner: mvngu
Type: enhancement | Status:
positive_review
Priority: major | Milestone: sage-5.0
Component: doctest | Keywords:
Work_issues: | Upstream: N/A
Reviewer: David Loeffler, Karl-Dieter Crisman | Author: Hugh
Thomas
Merged: | Dependencies:
---------------------------------------------------+------------------------
Changes (by kcrisman):
* status: needs_review => positive_review
* reviewer: David Loeffler => David Loeffler, Karl-Dieter Crisman
Old description:
> Improve the doctests for matrix/matrix0.pyx.
New description:
Improve the doctests for matrix/matrix0.pyx.
----
Apply [attachment:trac_12585_matrix0_doc-ht.patch] and
[attachment:trac_12585-review.patch].
--
Comment:
Looks pretty good. Considering that the changes you made after colons
were all in underscored functions, so they didn't appear in the reference
manual anyway, Hugh did good work too :)
Question:
{{{
def unpickle(cls, parent, mutability, cache, data, version):
r"""
Unpickle a matrix. This is only used internally by Sage. Users
should never call this function directly.
EXAMPLES: We illustrating saving and loading several different
types of matrices.
OVER `\ZZ`::
sage: A = matrix(ZZ,2,range(4))
sage: loads(dumps(A)) # indirect doctest
[0 1]
[2 3]
Sparse OVER `\QQ`:
Dense over `\QQ[x,y]`:
Dense over finite field.
"""
}}}
? Since this was there before, I guess it's not necessarily going to make
this 'needs work', but I am a little mystified by what the story behind
this is. Should we open a ticket for this?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12585#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
