#6588: Categories for root systems
----------------------------------------------+-----------------------------
Reporter: nthiery | Owner: mhansen
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: combinatorics | Keywords: root systems,
categories
Work_issues: | Upstream: N/A
Reviewer: Anne Schilling, Mark Shimozono | Author: Nicolas M.
Thiéry
Merged: | Dependencies: #10817
----------------------------------------------+-----------------------------
Comment(by nthiery):
Thanks much Anne for your detailed review!
Replying to [comment:10 aschilling]:
> - In /sage/categories/affine_weyl_groups.py there is a new import
> from sage.categories.infinite_enumerated_sets import
InfiniteEnumeratedSets
> which is not used. Please either remove this line or add
InfiniteEnumeratedSets
> in the class (which is probably preferable).
Good point. Done!
> - In /sage/categories/affine_weyl_groups.py please add a
`TestSuite(s).run()` doctest.
Done.
> - I am not sure this is related to the patch, but there are some
> strange methods in /sage/categories/coxeter_groups.py without doctests:
CoxeterGroups is now 100% doctested.
> Should has_left_descent also be an abstract_method? Or is that implicit
through
> has_right_descent?
There is a default implementation for this method, so it's not abstract.
Indeed, it would be nice to track such dependencies in the documentation;
but we don't have the infrastructure for that.
> - Why is the cateogry RootLatticeRealization in
> /sage/combinat/root_system/root_lattice_realization.py
> here and not in categories (if it is a category as specified in the
docstring)?
>
> The same question holds for
WeightLatticeRealizations(Category_over_base_ring)
> in /sage/combinat/root_system/weight_lattice_realization.py.
>
> - When using the extended weight lattice, the list of fundamental
weights
> does not include `\delta`. On the other hand it is possible to input
> `\delta` into the method fundamental_weight. This seems a little
> inconsistent.
>
> {{{
> sage: Q = RootSystem(['A', 3, 1]).weight_lattice(extended = True); Q
> Extended weight lattice of the Root system of type ['A', 3, 1]
> sage: Q.fundamental_weights()
> Finite family {0: Lambda[0], 1: Lambda[1], 2: Lambda[2], 3:
Lambda[3]}
> sage: Q.fundamental_weight('delta')
> delta
> }}}
>
More on those after lunch!
> Also, I posted a first reviewer's patch on sage-combinat with mostly
just
> trivial changes. Please fold it if you are satisfied.
Folded in! There is a new reviewer's patch on the patch server.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6588#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
