#11772: improving error reporting of random_matrix, and bug fixing
------------------------------+---------------------------------------------
Reporter: dimpase | Owner: jason, was
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Rob Beezer | Author:
Merged: | Dependencies:
------------------------------+---------------------------------------------
Old description:
> The error message of the call to random_matrix(QQ, 4, 8, rank=5) is quite
> cryptic.
> It should be easy to check that the rank is greater than min(nrows,ncols)
> and throw a ValueError with a meaningful message.
>
> A patch, which also fixes a similar small fly in random_subspaces_matrix,
> is attached.
> The cumulative patch incorporates more doctests, the fix for rank==1
> problem described in the comments, and puts a cup on the number of
> iterations in various while loops, so that they fail meaningfully.
>
> '''Apply''':
> 1. [attachment:trac_11772.patch]
New description:
The error message of the call to random_matrix(QQ, 4, 8, rank=5) is quite
cryptic.
It should be easy to check that the rank is greater than min(nrows,ncols)
and throw a ValueError with a meaningful message.
A patch, which also fixes a similar small fly in random_subspaces_matrix,
is attached.
The cumulative patch incorporates more doctests, the fix for rank==1
problem described in the comments, and puts a cup on the number of
iterations in various while loops, so that they fail meaningfully.
'''Apply''':
1. [attachment:trac_11772.2.patch]
--
Comment(by kini):
I couldn't find any revision onto which the patch actually applied, so I
tried to rebase it manually. Please check for errors.
Also, Dima, please remove your print statements and commented out lines...
the patch also needs some work in the PEP-8 department, but then again the
whole file does, it looks like. I fixed what I could in the function Rob
touched.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11772#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
