#12461: Replace some deprecated python functions in sage/algebras
------------------------------+---------------------------------------------
Reporter: aapitzsch | Owner: jason
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: misc | Keywords:
Work_issues: | Upstream: N/A
Reviewer: David Loeffler | Author: André Apitzsch
Merged: | Dependencies: #12484
------------------------------+---------------------------------------------
Changes (by davidloeffler):
* status: needs_review => needs_work
* reviewer: => David Loeffler
Comment:
I don't like the change at line 148 of {{{free_algebra_quotient}}}:
{{{
148 return isinstance(self, type(right)) and \
149 149 self.ngens() == right.ngens() and \
150 150 self.rank() == right.rank() and \
151 151 self.module() == right.module() and \
}}}
If {{{type(right)}}} was some very generic base class like !SageObject,
then the first statement would be True, but the remaining ones would be
completely meaningless, so you'd get weird errors being raised. It should
probably be {{{ isinstance(other, FreeAlgebraQuotient)}}} or something
like that.
That is my only disagreement with this patch, so if you can do a tiny fix
for that I'll happily give it a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12461#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
