#12659: build the sage library in place
---------------------------+------------------------------------------------
   Reporter:  mhansen      |          Owner:  GeorgSWeber 
       Type:  enhancement  |         Status:  needs_review
   Priority:  major        |      Milestone:  sage-5.0    
  Component:  build        |       Keywords:              
Work_issues:               |       Upstream:  N/A         
   Reviewer:               |         Author:  Mike Hansen 
     Merged:               |   Dependencies:              
---------------------------+------------------------------------------------

Comment(by was):

 Mike -- that makes sense.  However, why do we have this code still:
 {{{
         422             if not self.inplace:
         423                 relative_ext_dir =
 os.path.split(relative_ext_filename)[0]
         424                 prefixes = ['', self.build_lib,
 self.build_temp]
         425                 for prefix in prefixes:
         426                     path = os.path.join(prefix,
 relative_ext_dir)
         427                     try:
         428                         os.makedirs(path)
         429                     except OSError, e:
         430                         assert e.errno==errno.EEXIST, 'Cannot
 create %s.' % path
 }}}
 Wouldn't the above only be run if we are not building in place?   It seems
 to me that it would be best to either keep the code discussed in the
 comment above, or should replace all the code above by
 {{{
         422             if not self.inplace:
         423                ERROR MESSAGE
 }}}

 I'm in favor of the latter, unless I'm misunderstanding things.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12659#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to