#6588: Categories for root systems and many misc improvements
--------------------------------------------------------+-------------------
   Reporter:  nthiery                                   |          Owner:  
mhansen                 
       Type:  enhancement                               |         Status:  
positive_review         
   Priority:  major                                     |      Milestone:  
sage-5.0                
  Component:  combinatorics                             |       Keywords:  root 
systems, categories
Work_issues:                                            |       Upstream:  N/A  
                   
   Reviewer:  Anne Schilling, Mark Shimozono, PatchBot  |         Author:  
Nicolas M. ThiƩry       
     Merged:                                            |   Dependencies:  
#10817                  
--------------------------------------------------------+-------------------
Changes (by aschilling):

  * status:  needs_review => positive_review


Comment:

 > > How about self.fundamental_weights(extended = True) with default
 extended = False?
 >
 > Well, since it's an abuse, and one that we might want to get rid of,
 > I'd rather not abuse yet another function. Unless you have a natural
 > use case for this notation? (for the extended weight lattice, that's
 > just self.basis()).

 Ok, since this is in self.basis() I am satisfied.

 > Yes, thanks! I have folded together all patches and posted them
 > here. I also did the reindentation and renaming *_lattice_realization
 > -> *_lattice_realizations. On my side, the patch is good to go.

 Ok, thanks! Unless I hear otherwise from Mark, I'll set a positive review.

 Cheers,

 Anne

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6588#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to