#11475: improve prime_pi (speedup + small fixes)
--------------------------------------------------+-------------------------
Reporter: rohana | Owner: was
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: number theory | Keywords: primes,
prime counting, prime_pi
Work_issues: | Upstream: N/A
Reviewer: Yann Laigle-Chapuy, Leif Leonhardy | Author: R. Andrew
Ohana
Merged: | Dependencies:
--------------------------------------------------+-------------------------
Changes (by davidloeffler):
* status: needs_review => needs_work
Comment:
According to the patchbot logs there are some issues with documentation
formatting:
{{{
docstring of sage.functions.prime_pi.legendre_phi:39: WARNING: Duplicate
explicit target name: "rao2011".
docstring of sage.functions.prime_pi.partial_sieve_function:39: WARNING:
Duplicate explicit target name: "rao2011".
docstring of sage.functions.prime_pi.legendre_phi:39: WARNING: duplicate
citation RAO2011, other instance in
/storage/masiao/sage-5.0.beta8/devel/sage/doc/en/reference/sage/functions/prime_pi.rst
docstring of sage.functions.prime_pi.partial_sieve_function:39: WARNING:
duplicate citation RAO2011, other instance in
/storage/masiao/sage-5.0.beta8/devel/sage/doc/en/reference/sage/functions/prime_pi.rst
}}}
This is basically because there should be only one copy of the
bibliography entry in the file, rather than having it afresh in every
docstring that cites it.
Also, shouldn't the class !PrimePi derive from
sage.symbolic.function.BuiltinFunction, rather from the base Object class?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11475#comment:56>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
