#1013: Matrix_real_double_dense overrides parent numpy() method with less-
functional version
------------------------------+---------------------------------------------
Reporter: cwitty | Owner: jason
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-5.0
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: David Loeffler | Author: Mike Hansen
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by davidloeffler):
* status: needs_review => positive_review
* reviewer: => David Loeffler
Old description:
> Matrix_real_double_dense and Matrix_complex_double_dense both define a
> numpy() method that turns the matrix into the appropriate kind of numpy
> matrix. However, Matrix defines a numpy() method that takes an optional
> type argument, to say what kind of matrix to produce. The specialized
> classes should also take this optional type argument, and fall back to
> the slow method defined by Matrix if the type is not 'd' or 'D',
> respectively.
New description:
Matrix_real_double_dense and Matrix_complex_double_dense both define a
numpy() method that turns the matrix into the appropriate kind of numpy
matrix. However, Matrix defines a numpy() method that takes an optional
type argument, to say what kind of matrix to produce. The specialized
classes should also take this optional type argument, and fall back to the
slow method defined by Matrix if the type is not 'd' or 'D', respectively.
Apply [attachment:trac_1013-whitespace_removed.patch]
--
Comment:
Apply trac_1013-whitespace_removed.patch
Looks good and doctests pass. I'm frankly amazed that this patch has
survived for so long without bitrotting.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/1013#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
