#12667: category root lattice realization issue: infinite loop while trying to
reflect to the positive chamber
------------------------------+---------------------------------------------
Reporter: mshimo | Owner: sage-combinat
Type: defect | Status: new
Priority: major | Milestone: sage-5.0
Component: combinatorics | Keywords: root system
Work_issues: | Upstream: N/A
Reviewer: Anne Schilling | Author: Mark Shimozono
Merged: | Dependencies:
------------------------------+---------------------------------------------
Comment(by aschilling):
Hi Mark,
Here are some comments. First of all, I moved your patch up in the queue
since presumably
you want it to go into Sage soon. Then I can do the testing on the sage-
combinat queue.
- Please use "hg qrefresh -e" and add a description of the changes you
made. This should
appear at the beginning of the file. The same description can then be used
on the trac
server once you upload it there.
- Nicolas once told me that every method should have a one-line short
description.
Then a more detailed description can follow. So for example in your new
method
"def reflection" have one line with a description
Also, for consistency in
"Reflect ``self`` across the hyperplane orthogonal to `root`."
should it be "Reflects ...."?
- Please use the syntax
.. warning::
for the warning.
Also, there are doctest failures
sage -t "devel/sage-
combinat/sage/combinat/root_system/root_lattice_realizations.py"
**********************************************************************
File "/Applications/sage-5.0.beta7/devel/sage-
combinat/sage/combinat/root_system/root_lattice_realizations.py", line
522:
sage: Phi.cover_relations()
Exception raised:
Traceback (most recent call last):
File "/Applications/sage-5.0.beta7/local/bin/ncadoctest.py", line
1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/Applications/sage-5.0.beta7/local/bin/sagedoctest.py", line
38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/Applications/sage-5.0.beta7/local/bin/ncadoctest.py", line
1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_16[3]>", line 1, in <module>
Phi.cover_relations()###line 522:
sage: Phi.cover_relations()
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 1198, in cover_relations
return [c for c in self.cover_relations_iterator()]
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 1213, in
cover_relations_iterator
yield map(self._vertex_to_element,(u,v))
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 698, in _vertex_to_element
return self._list[vertex]
TypeError: tuple indices must be integers, not
RootSpace_with_category.element_class
**********************************************************************
File "/Applications/sage-5.0.beta7/devel/sage-
combinat/sage/combinat/root_system/root_lattice_realizations.py", line
527:
sage: Phi.cover_relations()
Exception raised:
Traceback (most recent call last):
File "/Applications/sage-5.0.beta7/local/bin/ncadoctest.py", line
1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/Applications/sage-5.0.beta7/local/bin/sagedoctest.py", line
38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/Applications/sage-5.0.beta7/local/bin/ncadoctest.py", line
1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_16[5]>", line 1, in <module>
Phi.cover_relations()###line 527:
sage: Phi.cover_relations()
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 1198, in cover_relations
return [c for c in self.cover_relations_iterator()]
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 1213, in
cover_relations_iterator
yield map(self._vertex_to_element,(u,v))
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 698, in _vertex_to_element
return self._list[vertex]
TypeError: tuple indices must be integers, not
RootSpace_with_category.element_class
**********************************************************************
File "/Applications/sage-5.0.beta7/devel/sage-
combinat/sage/combinat/root_system/root_lattice_realizations.py", line
532:
sage: Phi.cover_relations()
Exception raised:
Traceback (most recent call last):
File "/Applications/sage-5.0.beta7/local/bin/ncadoctest.py", line
1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/Applications/sage-5.0.beta7/local/bin/sagedoctest.py", line
38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/Applications/sage-5.0.beta7/local/bin/ncadoctest.py", line
1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_16[7]>", line 1, in <module>
Phi.cover_relations()###line 532:
sage: Phi.cover_relations()
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 1198, in cover_relations
return [c for c in self.cover_relations_iterator()]
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 1213, in
cover_relations_iterator
yield map(self._vertex_to_element,(u,v))
File "/Applications/sage-5.0.beta7/local/lib/python/site-
packages/sage/combinat/posets/posets.py", line 698, in _vertex_to_element
return self._list[vertex]
TypeError: tuple indices must be integers, not
RootSpace_with_category.element_class
**********************************************************************
1 items had failures:
3 of 9 in __main__.example_16
***Test Failed*** 3 failures.
For whitespace errors, see the file
/Users/anne/.sage//tmp/root_lattice_realizations_29723.py
[5.0 s]
----------------------------------------------------------------------
The following tests failed:
sage -t "devel/sage-
combinat/sage/combinat/root_system/root_lattice_realizations.py"
Total time for all tests: 5.0 seconds
------------
Though these doctest failures also seem to appear without your patch
applied.
Best,
Anne
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12667#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
