#12680: Fix (a single) hardcoded 'g++' in Singular 3-1-3-3
------------------------+---------------------------------------------------
Reporter: leif | Owner: leif
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Keywords: spkg CXX C++ compiler hard-coded
Work_issues: | Upstream: Not yet reported upstream; Will do
shortly.
Reviewer: | Author: Leif Leonhardy
Merged: | Dependencies:
------------------------+---------------------------------------------------
Changes (by newvalueoldvalue):
* status: new => needs_review
* author: => Leif Leonhardy
Old description:
> In `src/factory/GNUmakefile.in`, we currently have:
> {{{
> #!make
> # create cf_gmp.h
> cf_gmp.h: GNUmakefile gen_cf_gmp.template
> echo "#!/bin/sh" >gen_cf_gmp.sh
> echo "GMP_H_T=\"`g++ $(LIBCXXFLAGS) -M gen_cf_gmp.cc|grep gmp.h`
> \"" >>gen_cf_gmp.sh
> cat gen_cf_gmp.template >>gen_cf_gmp.sh
> $(SHELL) gen_cf_gmp.sh
> }}}
>
> The attached p6 spkg fixes this (by using `$(CXX)`, as everywhere else),
> and also two typos.
>
> ----
>
> This bug shows up (and leads to a build error) e.g. if you use a
> different C++ compiler (or version of `g++`) by setting `CXX` and specify
> `CXXFLAGS` the "default" `g++` doesn't understand.
New description:
In `src/factory/GNUmakefile.in`, we currently have:
{{{
#!make
# create cf_gmp.h
cf_gmp.h: GNUmakefile gen_cf_gmp.template
echo "#!/bin/sh" >gen_cf_gmp.sh
echo "GMP_H_T=\"`g++ $(LIBCXXFLAGS) -M gen_cf_gmp.cc|grep gmp.h`
\"" >>gen_cf_gmp.sh
cat gen_cf_gmp.template >>gen_cf_gmp.sh
$(SHELL) gen_cf_gmp.sh
}}}
The attached p6 spkg fixes this (by using `$(CXX)`, as everywhere else),
and also two typos.
----
This bug shows up (and leads to a build error) e.g. if you use a different
C++ compiler (or version of `g++`) by setting `CXX` and specify `CXXFLAGS`
the "default" `g++` doesn't understand.
----
'''New spkg:'''
[http://boxen.math.washington.edu/home/leif/Sage/spkgs/singular-3-1-3-3.p6.spkg]
'''md5sum:''' `c637e93eff14491d3dff11647b4732af singular-3-1-3-3.p6.spkg`
=== singular-3-1-3-3.p6 (Leif Leonhardy, March 17th 2012) ===
* #12680: Fix hardcoded 'g++' (and two typos) in factory/GNUmakefile.in.
--
Comment:
Haven't yet looked whether there are other changes pending; I apologize
for that.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12680#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
