#11584: DegreeSequences class !
-----------------------------+----------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: graph theory | Keywords:
Work_issues: | Upstream: N/A
Reviewer: David Coudert | Author: Nathann Cohen
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by dcoudert):
* status: needs_review => needs_work
* reviewer: => David Coudert
Comment:
Hi Nathann,
I tried the patch on sage-5.0.beta8.
* Installation OK
* functionality OK (I can play with degree sequences and generate
graphs,...)
* long tests (sage -t --verbose --long -force_lib
sage/combinat/degree_sequences.pyx) OK
* docbuild OK
However, I have some minor comments:
* In the html doc, one `min` should be replaced with a `\min`
{{{
63 .. MATH::
64 \sum_{j\leq i}d_j \leq j(j-1) + \sum_{j>i}min(d_j,i)
65
}}}
* The inline doc is rather limited and doesn't look nice.
{{{
sage: DegreeSequences?
Type: classobj
String Form: sage.combinat.degree_sequences.DegreeSequences
Namespace: Interactive
Loaded File: /path-to-sage/sage-5.0.beta8/local/lib/python2.7/site-
packages/sage/combinat/degree_sequences.so
Source File: /path-to-
sage/sage-5.0.beta8/devel/sage/sage/combinat/degree_sequences.so
Docstring:
Constructor
TEST:
sage: DegreeSequences(6)
Degree sequences on 6 elements
Constructor information:
Definition: DegreeSequences(self, n)
Docstring:
Constructor
TEST:
sage: DegreeSequences(6)
Degree sequences on 6 elements
sage:
}}}
As soon as these minor comments are addressed, I think the patch will be
ready to go.
Best,
D.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11584#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
