#12681: Fix hardcoded 'g++' in Lcalc 1.23 [p9]
------------------------+---------------------------------------------------
Reporter: leif | Owner: leif
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Keywords: spkg CC CXX C++ compiler hard-coded
Work_issues: | Upstream: N/A
Reviewer: | Author: Leif Leonhardy
Merged: | Dependencies:
------------------------+---------------------------------------------------
Changes (by newvalueoldvalue):
* cc: rishi, jdemeyer, rohana (added)
* status: new => needs_review
* author: => Leif Leonhardy
Old description:
> The horrible `Makefile` still uses `CC` for compiling C++ (as well as C),
> and hardcodes it to `g++`.
>
> The updated spkg (p10) fixes this by using `$(CXX)` for compiling C++,
> and allows both `CC` and `CXX` in the `Makefile` to get overridden by
> their respective environment settings.
New description:
The horrible `Makefile` still uses `CC` for compiling C++ (as well as C),
and hardcodes it to `g++`.
The updated spkg (p10) fixes this by using `$(CXX)` for compiling C++, and
allows both `CC` and `CXX` in the `Makefile` to get overridden by their
respective environment settings.
----
'''New spkg:'''
[http://boxen.math.washington.edu/home/leif/Sage/spkgs/lcalc-1.23.p10.spkg]
'''md5sum:''' `a37f527cbfeb24eef307574a5665c7a8 lcalc-1.23.p10.spkg`
=== lcalc-1.23.p10 (Leif Leonhardy, March 17th 2012) ===
* #12681: Fix hard-coded 'g++'.
The (patched) Makefile now uses $(CXX) (which *defaults* to 'g++')
for compiling and linking C++, $(CC) (which *defaults* to 'gcc') for
compiling C, although the latter is [currently] hardly used.
See also "Special Update/Build Instructions" above. (We could now also
set `INSTALL_DIR` and use 'make install'...)
--
Comment:
I've also attached a diff between the resulting Makefiles (p9 vs. p10),
for review only of course.
I apologize in case there are already pending changes to the Lcalc spkg;
haven't searched for such (also since the p9 is quite new).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12681#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
