#12682: Fix "hardcoded" 'gcc' in ratpoints 2.1.3 [p2]
------------------------+---------------------------------------------------
Reporter: leif | Owner: leif
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Keywords: spkg CC compiler hard-coded
Work_issues: | Upstream: N/A
Reviewer: | Author: Leif Leonhardy
Merged: | Dependencies:
------------------------+---------------------------------------------------
Comment(by leif):
Replying to [comment:2 mjo]:
> I would just pass the environment variables to `$MAKE` to keep the size
of our patches down. Our goal should be zero patches. The `$INSTALL_DIR`
stuff should be quoted, though. Can we report that upstream?
Well, of course we could. Using `?=` is IMHO also more convenient and
less error-prone (although less portable, i.e., not supported by all
`make`s, which probably matters ''to upstream''), especially if you have a
couple of invocations of `make`, and/or a couple of variables to override.
If we submit a patch upstream, we should also add an alias `check` for the
`test` target, and probably more. I just needed a quick solution... ;-)
The best thing is always(?) to have a `configure` script which
''generates'' the Makefile(s) such that we don't have to patch them. (Cf.
Lcalc, which Rishikesh wanted to "autotoolize" a while ago...) For some
(small) packages this would of course be a bit overkill.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12682#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
