#12602: Rework download/extract code in sage-spkg
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: build | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jeroen Demeyer | Merged in:
Dependencies: #12479 | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by jdemeyer):
Replying to [comment:11 jhpalmieri]:
> On line 268, why `cd /`?
No real reason. I just wanted to make sure that `PKG_SRC` is an absolute
path. So doing "cd /" would give a failure if `PKG_SRC` had a relative
path.
I changed the relevant code to the safer
{{{
# Do a final check that PKG_SRC is a file with an absolute path
cd /
if [ ! -f "$PKG_SRC" ]; then
echo >&2 "Error: spkg file '$PKG_SRC' not found."
echo >&2 "This shouldn't happen, it is a bug in the sage-spkg script."
exit 1
fi
# Go back to SAGE_ROOT where we have less chance of completely messing
# up the system if we do something wrong.
cd "$SAGE_ROOT" || exit
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12602#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
