#10281: Multimodular echelon form over cyclotomic fields fails
---------------------------------------+------------------------------------
Reporter: mraum | Owner: jason, was
Type: defect | Status: needs_review
Priority: critical | Milestone:
Component: linear algebra | Resolution:
Keywords: cyclotomic, echelon | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
---------------------------------------+------------------------------------
Comment (by was):
Replying to [comment:10 mraum]:
> I have tested the spkg, and it is completely ok. The commit message
could be a bit more informative,
> but since it refers to the ticket, it's ok also.
>
> William, do you want to make the change suggested by Robert?
> Personally, I would keep the extern statements for clearness (they
obviously don't do any harm).
I did make the changes and updated the second patch. I didn't bother with
the beta2 patch, since that one will never get applied by the release
manager.
> If you don't intend to, then I would set this to positive review, so
that everything can be run on the build farm.
Please do. Thanks!
I have to point out that I was running some big modular symbols
computations over cyclotomic fields and found some "not enough primes"
issues even with this patch. That's because we only get to use split
primes. So it will be very important to revive the old
matrix_modn_dense code, but using a 64-bit int instead of 32-bit, so we
get modulo up to {{{2^32}}} (instead of {{{2^23}}}). (That is already
#4968.) I plan to do that this week or next week. The current patch
here is very good foundation for doing #4968 right.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10281#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
