#11358: matrix multiplication over ZZ sometimes gives incorrect results
----------------------------------------------------------------------+-----
       Reporter:  tomc                                                |         
Owner:                 
           Type:  defect                                              |        
Status:  positive_review
       Priority:  critical                                            |     
Milestone:  sage-5.0       
      Component:  linear algebra                                      |    
Resolution:                 
       Keywords:  matrix multiplication, multi-modular, integers, ZZ  |   Work 
issues:                 
Report Upstream:  N/A                                                 |     
Reviewers:                 
        Authors:                                                      |     
Merged in:                 
   Dependencies:                                                      |      
Stopgaps:  #12710         
----------------------------------------------------------------------+-----
Changes (by dsm):

  * status:  needs_review => positive_review


Comment:

 The new patch:

 (1) Applies against 5.0.beta8 with minor fuzz.
 (2) Seems to eliminate the original bug.
 (3) Matches the original diagnosis about where the problem was (use of
 repeated primes in a multimodular basis), so I get why it *should* fix the
 bug.
 (4) Has doctests which verify that .._height now behaves.
 (5) The new version passes my separate tests confirming that the other
 _extend methods behave too, while the first version didn't.

 Positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11358#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to