#12486: Add patchbot to Sage itself.
-------------------------------+--------------------------------------------
Reporter: robertwb | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: doctest | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
-------------------------------+--------------------------------------------
Comment (by davidloeffler):
Sorry, the issue I reported the last time is a non-issue (you just have to
wait a bit longer for the Tee background process to notice that it's
finished).
But there is an amusing bug which I spotted when running a patchbot under
5.0.beta10. The function that compares version numbers just splits on "."
and sorts alphabetically, and hence it thinks beta1 < beta10 < beta2! This
caused a bunch of spurious "Apply Failed" warnings when it tried to apply
patches from tickets that had already been merged (listed as dependencies
of open tickets). See for example the first of the two runs for ticket
#10527.
The fix is to add the lines
{{{
#!python
a = a.replace("beta", "beta.")
b = b.replace("beta", beta.")
}}}
to util.compare_versions.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12486#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
