#12498: Return Integer from GeneralDiscreteDistribution
------------------------------------------------------+---------------------
       Reporter:  ppurka                              |         Owner:  amhou   
    
           Type:  defect                              |        Status:  
needs_review
       Priority:  minor                               |     Milestone:  
sage-5.0    
      Component:  statistics                          |    Resolution:          
    
       Keywords:  GeneralDiscreteDistribution import  |   Work issues:          
    
Report Upstream:  N/A                                 |     Reviewers:          
    
        Authors:                                      |     Merged in:          
    
   Dependencies:  #9770                               |      Stopgaps:          
    
------------------------------------------------------+---------------------
Changes (by ppurka):

  * status:  needs_work => needs_review
  * work_issues:  needs rebase =>


Old description:

> 1. The output of `GeneralDiscreteDistribution().get_random_element()` is
> not a Sage number per se and hence has no `parent` attribute.
>
> 2. The import of sage.rings.real_double seems unnecessary in the file
> `devel/sage/sage/gsl/probability_distribution.pyx` since all the calls to
> RDF are made explicitly as `sage.rings.real_double.RDF` in the entire
> file.
>
> Attaching a patch to fix both the above issues. The patch passes all
> doctests in `devel/sage/sage/gsl`.
> ----
> Apply [attachment:trac_12498-return-Integer-from-
> GeneralDiscreteDistribution.patch] to `devel/sage`

New description:

 1. The output of `GeneralDiscreteDistribution().get_random_element()` is
 not a Sage number per se and hence has no `parent` attribute.

 2. The import of sage.rings.real_double seems unnecessary in the file
 `devel/sage/sage/gsl/probability_distribution.pyx` since all the calls to
 RDF are made explicitly as `sage.rings.real_double.RDF` in the entire
 file.

 Attaching a patch to fix both the above issues. The patch passes all
 doctests in `devel/sage/sage/gsl`.
 ----
 Apply [attachment:trac_12498-return-Integer-from-
 GeneralDiscreteDistribution.2.patch] to `devel/sage` of sage-5.0beta10

--

Comment:

 Rebased to sage-5.0beta10.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12498#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to