#12311: In spkgs, run testcc.sh and testcxx.sh without explicit path
--------------------------------------------------+-------------------------
Reporter: jdemeyer | Owner: tbd
Type: defect | Status:
positive_review
Priority: minor | Milestone: sage-5.0
Component: packages | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Jeroen
Demeyer
Authors: John Palmieri | Merged in:
Dependencies: #11073, #11920, #12304, #12694 | Stopgaps:
--------------------------------------------------+-------------------------
Changes (by jdemeyer):
* status: needs_review => positive_review
* reviewer: => Jeroen Demeyer
Old description:
> #11073 changes the location of `testcc.sh` and `testcxx.sh` to
> `spkg/bin`. The following spkgs refer explicitly to
> `$SAGE_LOCAL/bin/testcc.sh`:
> * singular (fixed by #12562)
> * cliquer (also change the path to `sage-env` in a comment in
> `Makefile.patch`)
> * rubiks
> * sympow (fixed by #11920)
>
> The following spkgs have `testcc.sh` included in the spkg:
> * libm4ri
> * libm4rie (fixed by #12501)
>
> `testcxx.sh` is never used.
>
> Changing these spkgs should allow us to stop copying `testcc.sh` and
> `testcxx.sh` from `spkg/bin` to `local/bin`.
>
> ----
>
> New spkgs:
>
> -
> [http://boxen.math.washington.edu/home/palmieri/SPKG/cliquer-1.2.p11.spkg]
> -
> [http://boxen.math.washington.edu/home/palmieri/SPKG/libm4ri-20111004.p2.spkg]
> -
> [http://boxen.math.washington.edu/home/palmieri/SPKG/rubiks-20070912.p18.spkg]
>
> Apply [attachment:trac_12311-root.patch] to the root repository.
New description:
#11073 changes the location of `testcc.sh` and `testcxx.sh` to `spkg/bin`.
The following spkgs refer explicitly to `$SAGE_LOCAL/bin/testcc.sh`:
* singular (fixed by #12562)
* cliquer (also change the path to `sage-env` in a comment in
`Makefile.patch`)
* rubiks
* sympow (fixed by #11920)
The following spkgs have `testcc.sh` included in the spkg:
* libm4ri
* libm4rie (fixed by #12501)
`testcxx.sh` is never used.
Changing these spkgs should allow us to stop copying `testcc.sh` and
`testcxx.sh` from `spkg/bin` to `local/bin` in #12631.
----
New spkgs:
-
[http://boxen.math.washington.edu/home/palmieri/SPKG/cliquer-1.2.p11.spkg]
-
[http://boxen.math.washington.edu/home/palmieri/SPKG/libm4ri-20111004.p2.spkg]
-
[http://boxen.math.washington.edu/home/palmieri/SPKG/rubiks-20070912.p18.spkg]
--
Comment:
Looks good to me, thanks!
I propose not to apply the SAGE_ROOT patch and leave that to #12631.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12311#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
