#12220: Updated CBC spkg
---------------------------------------------+------------------------------
Reporter: ncohen | Owner: ncohen
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.0
Component: linear programming | Resolution:
Keywords: sd35.5, Cernay2012 | Work issues:
Report Upstream: N/A | Reviewers: John Perry,
Nathann Cohen
Authors: John Perry, Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------------------+------------------------------
Changes (by john_perry):
* status: needs_review => positive_review
Comment:
Replying to [comment:87 ncohen]:
> > * `range(number)` to `xrange(number)` in `coin_backend.pyx`?
>
> Hmmmm... You think it is faster ? I thought that the "for i in range(n)"
were directly translated to C loops when used in a Python file.
In Python, `range(number)` creates a list of numbers from 0 to `n-1`,
while `xrange(number)` is supposed to be more efficient if you don't need
the list.
But, you're right about Cython. I looked at the annotated html, and Cython
is smart enough not to build the list. So it isn't a problem after all. I
had just never checked that before, and assumed that Cython built the list
just as Python did.
> > * adding me as an author? I forgot to do that in the patches I
originally submitted (& some work is mine)
>
> Oh sorry ! You mean in the HG patches ? Actually the "all tests pass"
contains only your name as the author (I folded many patches and the first
one was probably yours) `:-)`
Not my name in the patch, but my name in the source code. The source code
for `coin_backend.pyx` doesn't list me as an author. It's only:
{{{
"""
COIN Backend
AUTHORS:
- Nathann Cohen (2010-10): initial implementation
"""
}}}
I'm giving it a positive review anyway (it passes the doctests, even on a
mac), but please consider it.
john
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12220#comment:88>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
