#12784: Add comment to deps explaining dependency of cvxopt on matplotlib
---------------------------------+------------------------------------------
       Reporter:  jhpalmieri     |         Owner:  GeorgSWeber 
           Type:  enhancement    |        Status:  needs_review
       Priority:  major          |     Milestone:  sage-5.0    
      Component:  build          |    Resolution:              
       Keywords:                 |   Work issues:              
Report Upstream:  N/A            |     Reviewers:              
        Authors:  John Palmieri  |     Merged in:              
   Dependencies:  #12742         |      Stopgaps:              
---------------------------------+------------------------------------------

Comment (by kcrisman):

 Is there anything to review here?  I read the sage-devel thing, and I
 don't see why this wouldn't take care of the issue.  But I don't want to
 get in trouble with those worried about (re)build times...

 Although I should point out
 {{{
 sage: hg_root.apply('http://trac.sagemath.org/sage_trac/raw-
 attachment/ticket/12784/trac_12784-cvxopt-deps.patch')
 Attempting to load remote file: http://trac.sagemath.org/sage_trac/raw-
 attachment/ticket/12784/trac_12784-cvxopt-deps.patch
 Loading: [.]
 cd "/Users/.../sage-5.0.beta11" && sage --hg import
 "/Users/.../40120/tmp_0.patch"
 applying /Users/.../40120/tmp_0.patch
 patching file spkg/standard/deps
 Hunk #1 FAILED at 544
 1 out of 1 hunks FAILED -- saving rejects to file spkg/standard/deps.rej
 abort: patch failed to apply
 }}}
 I think due to the formatting of the patch file for some reason.
 {{{

 diff --git a/spkg/standard/deps b/spkg/standard/deps
 --- a/spkg/standard/deps
 +++ b/spkg/standard/deps
 @@ -545,6 +545,7 @@ SAGERUNTIME = $(INST)/$(SAGE_SCRIPTS) $(
                   $(INST)/$(LAPACK) $(INST)/$(BLAS) $(INST)/$(NUMPY)
 $(INST)/$(PATCH)
 }}}
 should the `SAGERUNTIME` be in the same line as the `@@`?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12784#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to