#12789: Move local/bin/sage-check-64 to spkg/bin/sage-arch-env
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: leif
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: scripts | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Description changed by jdemeyer:
Old description:
> Since `sage-env` sources `$SAGE_LOCAL/bin/sage-check-64`, it makes sense
> to move the latter file to `$SAGE_ROOT/spkg/bin`. I also propose to
> rename the file to "sage-arch-env". I would like to support a SAGE32
> flag (see #12726) and it makes sense to use the same file for this.
>
> Further changes:
> 1. use `$SAGE_LOCAL/etc/sage-64.txt` as indicator file for `SAGE64`
> instead of `$SAGE_LOCAL/lib/sage-64.txt` (`sage-64.txt` looks more like a
> configuration file than a library).
> 2. remove all "echo" statements from `sage-check-64` (they were being
> redirected to /dev/null anyway).
> 3. move the sourcing of this file up in sage-env, before the compiler
> flags are set. This would allow changing the default compiler flags,
> depending on `SAGE64` or other future architecture flags.
>
> '''Apply''':
> 1. [attachment:12789_scripts.patch] to the SCRIPTS repository.
> 2. [attachment:12789_root.patch] to the ROOT repository.
New description:
Since `sage-env` sources `$SAGE_LOCAL/bin/sage-check-64`, it makes sense
to move the latter file to `$SAGE_ROOT/spkg/bin`. I also propose to
rename the file to "sage-arch-env". I would like to support a SAGE32 flag
(see #12726) and it makes sense to use the same file for this.
Further changes:
1. use `$SAGE_LOCAL/etc/sage-64.txt` as indicator file for `SAGE64`
instead of `$SAGE_LOCAL/lib/sage-64.txt` (`sage-64.txt` looks more like a
configuration file than a library).
2. remove all "echo" statements from `sage-check-64` (they were being
redirected to /dev/null anyway).
3. move the sourcing of this file up in sage-env, before the compiler
flags are set. This would allow changing the default compiler flags,
depending on `SAGE64` or other future architecture flags.
4. remove sourcing of `sage-check-64` from `local/bin/sage-build`. The
latter script is only called from `spkg/bin/sage` at which point `SAGE64`
is already set if needed.
'''Apply''':
1. [attachment:12789_scripts.patch] to the SCRIPTS repository.
2. [attachment:12789_root.patch] to the ROOT repository.
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12789#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
