#12777: Add signal handling to libecm.pyx
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.0
Component: factorization | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Paul Zimmermann
Authors: Jeroen Demeyer | Merged in:
Dependencies: #12757 | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by zimmerma):
* status: needs_review => positive_review
* work_issues: cf issues in comment 7 =>
Comment:
one doctest fails:
{{{
tarte% ./sage -t devel/sage-12777/sage/misc/sagedoc.py
sage -t "devel/sage-12777/sage/misc/sagedoc.py"
**********************************************************************
File
"/localdisk/tmp/sage-5.0.beta11/devel/sage-12777/sage/misc/sagedoc.py",
line 566:
sage: 'abvar/homology' in _search_src_or_doc('doc', 'homology',
'variety', interact=False)
Expected:
True
Got:
Warning, the following Sage documentation hasn't been built,
so documentation search results may be incomplete:
<BLANKLINE>
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/de/tutorial
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/faq
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/constructions
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/bordeaux_2008
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/a_tour_of_sage
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/reference
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/developer
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/installation
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/tutorial
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/numerical_sage
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/website
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/en/thematic_tutorials
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/fr/a_tour_of_sage
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/fr/tutorial
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/ru/tutorial
/localdisk/tmp/sage-5.0.beta11/devel/sage/doc/output/html/tr/a_tour_of_sage
<BLANKLINE>
You can build these with 'sage -docbuild DOCUMENT html',
where DOCUMENT is one of 'de/tutorial', 'faq', 'constructions',
'bordeaux_2008', 'a_tour_of_sage', 'reference', 'developer',
'installation', 'tutorial', 'numerical_sage', 'website',
'thematic_tutorials', 'fr/a_tour_of_sage', 'fr/tutorial', 'ru/tutorial',
'tr/a_tour_of_sage',
or you can use 'sage -docbuild all html' to build all of the missing
documentation.
False
**********************************************************************
1 items had failures:
1 of 7 in __main__.example_8
***Test Failed*** 1 failures.
For whitespace errors, see the file
/users/caramel/zimmerma/.sage//tmp/sagedoc_29685.py
[20.6 s]
}}}
but it fails without the two patches, thus I give a positive review.
Paul
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12777#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
