#12799: Fix PolyBoRi's dependencies in `module_list.py`
----------------------------------------------------------------+-----------
Reporter: AlexanderDreyer |
Owner: AlexanderDreyer
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-5.0
Component: algebra |
Resolution:
Keywords: | Work
issues:
Report Upstream: None of the above - read trac for reasoning. |
Reviewers: Leif Leonhardy
Authors: Alexander Dreyer | Merged
in:
Dependencies: |
Stopgaps:
----------------------------------------------------------------+-----------
Changes (by {'newvalue': u'Alexander Dreyer', 'oldvalue': u'AlexanderDreyer'}):
* reviewer: => Leif Leonhardy
* author: AlexanderDreyer => Alexander Dreyer
Old description:
> Actually only the pbori module needs to get rebuilt; while touching
> $SAGE_LOCAL/include/polybori.h doesn't help, touching
> $SAGE_LOCAL/include/polybori/* does (afterwards running ./sage -b).
> The better alternative is to fix the dependency list in `module_list.py`
>
> === Current patch ===
> * '''Apply''' [attachment:polybori_depends.patch]
New description:
Actually only the `pbori` module needs to get rebuilt; while touching
`$SAGE_LOCAL/include/polybori.h` doesn't help, touching
`$SAGE_LOCAL/include/polybori/*` does (afterwards running `./sage -b`).
The better alternative is to fix the dependency list in `module_list.py`
=== Current patch ===
* '''Apply''' [attachment:polybori_depends.patch]
--
Comment:
As mentioned on #12655, I'd rather make the extension module depend on
just `$SAGE_INC/polybori.h` and/or its libraries,
`$SAGE_LOCAL/lib/{polybori,polybori_groebner}.so`, and `touch` the former
from `spkg-install` at least in case you don't add the libraries.
AFAIK Cython is smart enough to notice when (at least ''directly'')
included headers are newer, but this doesn't help if their timestamps are
preserved during !PolyBoRi's installation.
Adding ''all of'' !PolyBoRi's headers ''explicitly'' seems a bit overkill
to me.
[Also note that we have both `$SAGE_INC/polybori.h` and
`$SAGE_INC/polybori/polybori.h`, which are not the same files.]
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12799#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
