#12813: contour_plot region option
-------------------------------+--------------------------------------------
       Reporter:  aerusso      |         Owner:  jason, was
           Type:  enhancement  |        Status:  new       
       Priority:  minor        |     Milestone:            
      Component:  graphics     |    Resolution:            
       Keywords:               |   Work issues:            
Report Upstream:  N/A          |     Reviewers:            
        Authors:               |     Merged in:            
   Dependencies:               |      Stopgaps:            
-------------------------------+--------------------------------------------

Comment (by kcrisman):

 Great start.  Here are some things to keep in mind with a revision.
  * We want examples in the documentation!  To show off this new
 functionality :)
  * You seem to have a lot of extra whitespace in the doc part of the patch
 - maybe unneeded extra line breaks?
  * Does the numpy solution cause any horrible timings?  I assume not, but
 we wouldn't want using the `region` keyword to slow things down so much
 that it's not usable.
  * Is there any way to use an `assert` statement to ensure that `region`
 is in the right form?  Just curious, maybe it's too cumbersome.
  * You ''should'' be able to use
 [http://www.sagemath.org/doc/developer/producing_patches.html the
 developer guide instructions] to produce your patch.  Mainly, this is to
 make sure the patch includes your information (for credit and contact) and
 has at least a short description of what this patch fixes in the commit
 message.  Feel free to put any specific instructions that aren't working
 here.
  * Oh, and put your "real name" in the Author section so that when your
 contribution is included you are properly acknowledged - this is very
 important for us to give credit where it's due.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12813#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to