#12821: testcc.sh: allow $CC to contain multiple words
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: build | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Leif Leonhardy
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by leif):
* reviewer: => Leif Leonhardy
Comment:
Stylewise, I'd use `[ $# -lt 1 ]`.
The usage should say "`$0 name_or_path_to_the_C_compiler [optional
arguments]`".
I'd also use `$@` instead of `"$@"`, then quoting `$CC` doesn't hurt (so
you wouldn't have to change the M4RIE spkg either), and the latter won't
work as probably expected.
It's also a bit funny to use `grep ... | sed ...`; a single invocation of
`sed` is sufficient. (At least he didn't use `... | cat | ...` ;-) )
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12821#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
