#12845: Incorrect doctest in sage/misc/functional.py
------------------------------------+---------------------------------------
       Reporter:  mjo               |         Owner:  burcin      
           Type:  defect            |        Status:  needs_review
       Priority:  major             |     Milestone:  sage-5.0    
      Component:  symbolics         |    Resolution:              
       Keywords:                    |   Work issues:              
Report Upstream:  N/A               |     Reviewers:              
        Authors:  Michael Orlitzky  |     Merged in:              
   Dependencies:                    |      Stopgaps:              
------------------------------------+---------------------------------------

Comment (by mjo):

 Replying to [comment:2 novoselt]:
 > Should there also be another ticket for fixing the bug of the real
 assumption?

 Yes, there are at least two, #12737 and #12780. I separated this patch out
 because I wound up fixing the same doctest twice.

 The first bug, "fixed" by #12737 is that `simplify_radical()` ignores the
 domain anyway and goes nuts. "Simplify" there is really a misnomer, so the
 fix that I settled on was to remove it from `simplify_full()`:

 {{{
 sage: bool(norm(v).simplify_radical() == sqrt(a^2 + b^2 + c^2))
 True
 }}}

 The second more sneaky bug, #12780, is that `simplify_log()` sets the
 Maxima domain to `real` before it performs its simplifications. Thus,

 {{{
 sage: bool(norm(v).simplify_log() == sqrt(a^2 + b^2 + c^2))
 True
 }}}

 I think the fix there is straightforward: don't do that. This was the only
 doctest affected by not setting the domain to `real` during
 `simplify_log()`.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12845#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to