#11943: The category graph should comply with Python's method resolution order
-----------------------------------------------------------+----------------
Reporter: SimonKing | Owner:
nthiery
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-5.0
Component: categories | Resolution:
Keywords: category graph, method resolution order | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Simon King | Merged in:
Dependencies: #11900, #7980 | Stopgaps:
-----------------------------------------------------------+----------------
Comment (by nthiery):
There it is. Here is the diff between the two patches (oops, sorry, I did
the diff the wrong way):
{{{
diff --git a/sage/categories/algebras.py b/sage/categories/algebras.py
--- a/sage/categories/algebras.py
@@ -155,7 +155,7 @@
+ All the super categories of this category, including this
category.
- TEST::
-+ Since :trac:`11943`, the order of super categories is
++ Since trac ticket #11943, the order of super categories is
+ determined by Python's method resolution order C3 algorithm.
- sage: Rngs()._all_super_categories_raw()
@@ -193,7 +193,7 @@
+ r"""
+ All the proper super categories of this category.
+
-+ Since :trac:`11943`, the order of super categories is
++ Since trac ticket #11943, the order of super categories is
+ determined by Python's method resolution order C3 algorithm.
+
+ .. seealso:: :meth:`all_super_categories`
@@ -266,7 +266,7 @@
+ - ``proper`` -- a boolean (default: ``False``); whether to
exclude this category.
- FIXME:
-+ Since :trac:`11943`, the order of super categories is
++ Since trac ticket #11943, the order of super categories is
+ determined by Python's method resolution order C3 algorithm.
- - make sure that this is compatible with the python algorithm
@@ -422,7 +422,7 @@
- By trac ticket #11943, the list of categories returned by
:meth:`all_super_categories`
- is supposed to correspond to the method resolution order of the
parent or element
- classes. This method verifies it.
-+ By :trac:`11943`, the list of categories returned by
++ By trac ticket #11943, the list of categories returned by
+ :meth:`all_super_categories` is supposed to match with the
+ method resolution order of the parent and element
+ classes. This method checks this.
}}}
If you are happy with the changes, please fold the two patches, and double
check the patch header.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11943#comment:91>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
