#12827: Expand Animation class to accept more graphics types
-----------------------------------------+----------------------------------
       Reporter:  niles                  |         Owner:  jason, was           
                        
           Type:  enhancement            |        Status:  needs_review         
                        
       Priority:  major                  |     Milestone:  sage-5.0             
                        
      Component:  graphics               |    Resolution:                       
                        
       Keywords:  animate, graphics, 3D  |   Work issues:  docstrings, testing, 
think about img protocol
Report Upstream:  N/A                    |     Reviewers:                       
                        
        Authors:  Niles Johnson          |     Merged in:                       
                        
   Dependencies:                         |      Stopgaps:                       
                        
-----------------------------------------+----------------------------------
Changes (by niles):

  * status:  new => needs_review


Old description:

> Currently the `Animation` class only animates `Graphics` objects, and
> throws an error for `Graphics3d`, `GraphicsArray`, and `Tachyon` objects.
> The behavior of this class should be improved to accept any Sage object
> whose `save` method produces an image.
>
> See this [https://groups.google.com/forum/?fromgroups#!topic/sage-
> devel/9TzVOj70ADU sage-devel] thread for the beginning of this
> discussion, including some discussion of possible solutions.

New description:

 Currently the `Animation` class only animates `Graphics` objects, and
 throws an error for `Graphics3d`, `GraphicsArray`, and `Tachyon` objects.
 The behavior of this class should be improved to accept any Sage object
 whose `save` method produces an image.

 See this [https://groups.google.com/forum/?fromgroups#!topic/sage-
 devel/9TzVOj70ADU sage-devel] thread for the beginning of this discussion,
 including some discussion of possible solutions.


 == Apply ==

 * [attachment:trac_12827_animate3d_save_image.patch]

--

Comment:

 Thanks for all the feedback.  Having thought through the issues here, I'd
 like to provide a minimal solution to the animation problem now which
 doesn't conflict with potential future improvements to the graphics
 objects.  I've opted for a `save_image` method which just passes its
 arguments to the `save` method.  This can save in bitmap or vector
 formats, depending on the capabilities of the `save` method, and sizing of
 the output image will depend on the `save` method too.

 All tests pass in the affected files, and all of the documentation builds
 without warning; Nils or Jonathan, are either of you interested in
 reviewing this?

 Patchbot: apply trac_12827_animate3d_save_image.patch

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12827#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to