#8119: Rename change the hash value of some objects
-----------------------------------+----------------------------------------
Reporter: hivert | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.0
Component: misc | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Florent Hivert, Nicolas M.
Thiéry, Nicolas Borie
Authors: Robert Bradshaw | Merged in:
Dependencies: | Stopgaps:
-----------------------------------+----------------------------------------
Changes (by hivert):
* status: needs_review => positive_review
Old description:
> For many objects the hash value is computed from {{{__repr__}}}. This is
> a bad idea since renaming the object change its hash value.
> {{{
> sage: bla = PolynomialRing(ZZ,"x")
> sage: hash(bla)
> -1525918542791298668
> sage: bla.rename("toto")
> sage: hash(bla)
> 2314052222105390764
> }}}
>
> '''Apply Only:'''
> 1. [attachment:8119-parent-hash-final-fix32.patch]
New description:
For many objects the hash value is computed from {{{__repr__}}}. This is a
bad idea since renaming the object change its hash value.
{{{
sage: bla = PolynomialRing(ZZ,"x")
sage: hash(bla)
-1525918542791298668
sage: bla.rename("toto")
sage: hash(bla)
2314052222105390764
}}}
'''Apply Only:'''
1. [attachment:8119-parent-hash-final.patch]
--
Comment:
Hi there,
I'm setting a positive review here but I uploaded a new patch removing a
trailling whitespace which bothered the patchbot. The only difference
between
[attachment:8119-parent-hash-final-fix32.patch] and
[attachment:8119-parent-hash-final.patch] is the trailling space (and of
course
Mercurials header), so I don't think a new review is needed.
Florent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8119#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
