#12872: A show method for permutations
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by ncohen):
Hellooooooooo !!!
> but shouldn't you had some tests to the function?
Well, there are 4 ! Of course the image are not "checked", but the code is
run anyway and nothing crashes.. That's more or less all we can do with
the docstring system :-/
> * paralell -> parallel
Arggggggggggggggggggggg !!!
> * why are you using "chord-diagram" instead of "circular"?
Oh. Well, because it is the word that the guys from Sage-combinat picked
the most naturally. I like permutations but that's their stuff much more
than mine, so that they hold for True is true for me `:-D`
> * You could use capitalize() in tests to ease usage.
Hmmmm. Well, I think that it had some meaning to do this for our LP
solvers because we never know which letters should be upper case and which
one are not (Gurobi or GUROBI ? Cplex or CPLEX), but let's not add a layer
of administration to *all* the functions that take a parameter like that.
I added a "else" statement though, so that there is an exception raised if
the given string does not match any of the good ones. These arguments are
always lower-case anyway.
Patch updated !
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12872#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
