#12874: Recognition of Comparability graphs and Permutation graphs
----------------------------------+-----------------------------------------
Reporter: ncohen | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: David Coudert
Authors: Nathann Cohen | Merged in:
Dependencies: #12816, #12872 | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by dcoudert):
The documentation is now build without warnings and is well displayed.
However, I found some typos.
In comparability.pyx
* "incmparable" -> "incomparable"
* "paralell" -> "parallel"
* "thee two edges" -> "the two edges" or "these two edges"
* "tranitive" -> "transitive"
* "i.e" -> "i.e."
* "cocomparability" -> "co-comparability" (x2)
* In the documentation, the sentence "But the Bull graph is" appears
without ":" at the end, but the sentence "The 5-cycle or the Petersen
Graph are not transitively orientable:" has. This is certainly due to
white space between "But the Bull graph is" and "::" in the source code.
* "Beware, for this implementation is unable to return negative
certificates" -> "Beware, this implementation is unable to return negative
certificates !"
* "returned indeed create the expected" -> "returned indeed creates the
expected" ?
Some methods have examples but no tests. Are examples handled as tests
when applying tests to the module ?
In graph.py
* lines 2500 - 2502 could be put in 80 cols
* line 2514 - ... : why are your using lists that are later converted to
sets? shouldn't you directly use sets ?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12874#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
