#11608: RDF/CDF eigenvalues: symmetric matrices, multiplicities
----------------------------------+-----------------------------------------
       Reporter:  rbeezer         |         Owner:  jason, was  
           Type:  enhancement     |        Status:  needs_work  
       Priority:  minor           |     Milestone:  sage-5.0    
      Component:  linear algebra  |    Resolution:              
       Keywords:                  |   Work issues:              
Report Upstream:  N/A             |     Reviewers:  Volker Braun
        Authors:  Rob Beezer      |     Merged in:              
   Dependencies:                  |      Stopgaps:              
----------------------------------+-----------------------------------------

Comment (by rbeezer):

 Replying to [comment:8 vbraun]:
 > On Fedora 16 x86_64, I get...

 Thanks, I'll increase the tolerance and that should work better across
 platforms.  You'd think I'd get the hang of this numerical stuff...


 > Minor nitpicks while we are at it:
 >   * Can you return a tuple (=immutable) instead of a list?

 I'm not opposed, but other eigenvalue routines return mutable objects.
 I'd prefer to do one grand change across all matrix types, on a single-
 purpose ticket of its own.

 {{{
 sage: A = matrix(QQ, [[1]])
 sage: ev=A.eigenvalues()
 sage: type(ev)
 <class 'sage.structure.sequence.Sequence_generic'>
 sage: ev[0]=5
 sage: ev
 [5]
 }}}

 >   * the symmetric docstring, how about: "converts `self` to a real
 matrix and applies the algorithm for Hermitian matrices". Note:
 technically you convert (explicit), not coerce (implicit).
 >   * in the hermitian docstring, how about: "uses the
 :meth:`~scipy.linalg.eigh` method from !SciPy, which applies only to real
 symmetric or complex Hermitian matrices. Since...". This would make it
 clear that the `syevr` implementation is used if possible.
 >   * the ".. warning::" block is not indented, so it is not typeset
 correctly.

 Thanks for the nits.  I'll make some changes right now.

 Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11608#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to